Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #130934

Merged
merged 14 commits into from
Sep 27, 2024
Merged

Rollup of 7 pull requests #130934

merged 14 commits into from
Sep 27, 2024

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    aec9116 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    d2c58ec View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    36455c6 View commit details
    Browse the repository at this point in the history
  2. Move Apple linker args from rustc_target to rustc_codegen_ssa

    They are dependent on the deployment target and SDK version, but having
    these in `rustc_target` makes it hard to introduce that dependency.
    madsmtm committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fb10eeb View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Use &raw in the compiler

    Like rust-lang#130865 did for the standard library, we can use `&raw` in the
    compiler now that stage0 supports it. Also like the other issue, I did
    not make any doc or test changes at this time.
    cuviper committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4160a54 View commit details
    Browse the repository at this point in the history
  2. Fix error span when arg to asm!() is a macro call

    When the template string passed to asm!() is produced by
    a macro call like concat!() we were producing wrong error
    spans. Now in the case of a macro call we just use the entire
    arg to asm!(), macro call and all, as the error span.
    gurry committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3dd583d View commit details
    Browse the repository at this point in the history
  3. update outdated comments

    lcnr committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9766192 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#129087 - slanterns:option_get_or_insert_def…

    …ault, r=dtolnay
    
    Stabilize `option_get_or_insert_default`
    
    Closes: rust-lang#82901.
    
    `@rustbot` label: +T-libs-api
    
    r? libs-api
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e76eb96 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#130435 - madsmtm:move-apple-link-args, r=pe…

    …trochenkov
    
    Move Apple linker args from `rustc_target` to `rustc_codegen_ssa`
    
    They are dependent on the deployment target and SDK version, but having these in `rustc_target` makes it hard to introduce that dependency. Part of the work needed to do rust-lang#118204, see rust-lang#129342 for some discussion.
    
    Tested using:
    ```console
    ./x test tests/run-make/apple-deployment-target --target="aarch64-apple-darwin,aarch64-apple-ios,aarch64-apple-ios-macabi,aarch64-apple-ios-sim,aarch64-apple-tvos,aarch64-apple-tvos-sim,aarch64-apple-visionos,aarch64-apple-visionos-sim,aarch64-apple-watchos,aarch64-apple-watchos-sim,arm64_32-apple-watchos,armv7k-apple-watchos,armv7s-apple-ios,x86_64-apple-darwin,x86_64-apple-ios,x86_64-apple-ios-macabi,x86_64-apple-tvos,x86_64-apple-watchos-sim,x86_64h-apple-darwin"
    IPHONEOS_DEPLOYMENT_TARGET=10.0 ./x test tests/run-make/apple-deployment-target --target=i386-apple-ios
    ```
    
    `arm64e-apple-darwin` and `arm64e-apple-ios` have not been tested, see rust-lang#130085, neither is `i686-apple-darwin`, since that requires using an x86_64 macbook, and I currently can't get mine to work, see rust-lang#130434.
    
    CC `@petrochenkov`
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f9cd81f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#130459 - onur-ozkan:rust-lang#130449, r=alb…

    …ertlarsan68
    
    delete sub build directory "debug" to not delete the change-id file
    
    Fixes rust-lang#130449
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    56e5bfa View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#130873 - taiki-e:ppc64-atomic, r=Amanieu

    rustc_target: Add powerpc64 atomic-related features
    
    This adds the following two target features to unstable powerpc_target_feature.
    
    - `partword-atomics`: 8-bit and 16-bit atomic instructions (`l{b,h}arx` and `st{b,h}cx.`) ([definition in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/PowerPC/PPC.td#L170-L172))
    - `quadword-atomics`: 128-bit atomic instructions (`lqarx` and `stqcx.`) ([definition in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/PowerPC/PPC.td#L173-L175))
    
    Both features are [available on power8+](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/PowerPC/PPC.td#L408-L422), so enabled by default for `powerpc64le-*` targets.
    
    r? `@Amanieu`
    
    `@rustbot` label +O-PowerPC
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fd9d961 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#130916 - cuviper:compiler-raw_ref_op, r=com…

    …piler-errors
    
    Use `&raw` in the compiler
    
    Like rust-lang#130865 did for the standard library, we can use `&raw` in the
    compiler now that stage0 supports it. Also like the other issue, I did
    not make any doc or test changes at this time.
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a37f7f4 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#130917 - gurry:129503-ice-wrong-span-in-mac…

    …ros, r=chenyukang
    
    Fix error span if arg to `asm!()` is a macro call
    
    Fixes rust-lang#129503
    
    When the argument to `asm!()` is a macro call, e.g. `asm!(concat!("abc", "{} pqr"))`, and there's an error in the resulting template string, we do not take into account the presence of this macro call while computing the error span. This PR fixes that. Now we will use the entire thing between the parenthesis of `asm!()` as the error span in this situation e.g. for `asm!(concat!("abc", "{} pqr"))` the error span will be `concat!("abc", "{} pqr")`.
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    01fecf6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#130927 - lcnr:normalizes-to-comments, r=com…

    …piler-errors
    
    update outdated comments
    
    r? `@compiler-errors` cc `@gavinleroy`
    matthiaskrgr authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    966a0b7 View commit details
    Browse the repository at this point in the history