Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][PR for CI] refactoring #128974 #131632

Closed
wants to merge 79 commits into from
Closed

[WIP][PR for CI] refactoring #128974 #131632

wants to merge 79 commits into from

Conversation

maxcabrajac
Copy link
Contributor

Working on #128974
Please ignore

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2024

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in coverage tests.

cc @Zalathar

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-json Area: Rustdoc JSON backend labels Oct 13, 2024
@maxcabrajac
Copy link
Contributor Author

sorry I rebased a little to far and caused this

@maxcabrajac
Copy link
Contributor Author

@rustbot -A-meta -A-rustdoc-json

@clubby789 clubby789 removed A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-json Area: Rustdoc JSON backend labels Oct 13, 2024
@maxcabrajac maxcabrajac marked this pull request as draft October 14, 2024 18:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 15, 2024

☔ The latest upstream changes (presumably #131724) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 15, 2024
@maxcabrajac
Unify {visit,walk}_generic_param
d64f965
@maxcabrajac
Unify walk_crate
5887760
@maxcabrajac
Add visit_attr_args and Unify walk_attr_args
ad94bfd
@maxcabrajac
Add {visit,walk}_safety
5002c21
@maxcabrajac
Unify walk_ty
ba05c88
@maxcabrajac
Unify walk_assoc_item_constraint
b7078cf
@maxcabrajac
Unify walk_mac_call
364dc87
@maxcabrajac
Unify walk_attribute
0fa7e60
@maxcabrajac
Unify {visit,walk}_foreign_mod
f4e0a22
@maxcabrajac
Unify {visit,walk}_macro_def
ac7bb60
@maxcabrajac
Unify {visit,walk}_ty_alias_where_clauses
089d0ee
@maxcabrajac
Unify WalkItemKind and unimpl it for AssocItemKind
fcb93eb
@maxcabrajac
Unify {visit,walk}{,_foreign}_item
f42dcf1
@maxcabrajac
Unify FnKind
0595ae1
@maxcabrajac
Unify {visit,walk}_coroutine_kind
fd615f6
@maxcabrajac
Unify {visit,walk}_fn
9dbcb65
@maxcabrajac
Add {visit,walk}_constness
0bae806
@maxcabrajac
Unify {visit,walk}_fn_header
04239d4
@maxcabrajac
Add {visit,walk}_impl_polarity
2618c86
@maxcabrajac
Add {visit,walk}_defaultness
a8392b1
@maxcabrajac
Unify impl WalkItemKind for ItemKind
201db75
@maxcabrajac
Unify impl WalkItemKind for ForeignItemKind
b31b31b
@maxcabrajac
Unify {visit,walk}_assoc_item
0e75ea0
@maxcabrajac
Remove visit_expr_post
d6a89c1
@maxcabrajac
Unify walk_expr
f097c35
@maxcabrajac
Add flat maps to make_visit!
a6d7ecc
@maxcabrajac
Use make_visit! to write flat maps
6b814ca
@maxcabrajac
Add make_walk_flat_map
24465fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maxcabrajac @rustbot @rust-log-analyzer @bors @clubby789 @jieyouxu