-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v9, v8plus, and leoncasa target feature to sparc and use v8plus in create_object_file #132552
base: master
Are you sure you want to change the base?
Conversation
186aaa6
to
8b08994
Compare
I'm not very familiar with Rust, but from what I can tell it looks okay. Also, a word on this:
|
Thanks for the clarification. I think separating However, we are using LLVM 19 which ties In #131222 we are trying to adopt the same approach as in LLVM 19, but actually adding the |
☔ The latest upstream changes (presumably #129884) made this pull request unmergeable. Please resolve the merge conflicts. |
8b08994
to
4dab43e
Compare
These commits modify compiler targets. |
5ce4994
to
2597e97
Compare
2597e97
to
81374d7
Compare
Added commit to add (If it would be better to separate that commit into a separate PR, I would be happy to separate it.) |
This adds the following three unstable target features:
v9
: SPARC-V9 instructions (LLVM definition)IIUC, this is needed to implement Generate correct symbols.o for sparc-unknown-none-elf #131222 more robustly.See also Generate correct symbols.o for sparc-unknown-none-elf #131222 (comment)This is also needed to implement inline assembly support for SPARC (Basic inline assembly support for SPARC and SPARC64 #132472 (comment))EDIT: no longer needed Basic inline assembly support for SPARC and SPARC64 #132472 (comment)v8plus
: SPARC-V8+ ABI (LLVM definition)leoncasa
: CASA instruction1 of LEON3 and LEON4 processors (LLVM definition, LLVM feature name:hasleoncasa
)cc @thejpster @glaubitz
r? workingjubilee
Closes #132585
@rustbot label +O-SPARC +A-target-feature
Footnotes
Atomic CAS instruction ↩