Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added regression test for #122638 #135390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ranger-ross
Copy link
Contributor

Re-adds the test for #122638 😄
fixes #122638

r? @BoxyUwU

(please let me know if this can be improved. I am still fairly new to using compiletest)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 12, 2025

can you also not name the issue ice-issuenumber if everyone did this we'd wind up with thousands of tests just named 132932 which is quite hard to read through. Something like normalizing_with_unconstrained_impl_params as the test name would match up with what the original problem was

thanks for the PR :3

@ranger-ross
Copy link
Contributor Author

can you also not name the issue ice-issuenumber if everyone did this we'd wind up with thousands of tests just named 132932 which is quite hard to read through. Something like normalizing_with_unconstrained_impl_params as the test name would match up with what the original problem was

Ahh thanks, yeah I was struggling to come up with a good name while looking through the original issues. 😅

I renamed to normalizing_with_unconstrained_impl_params.rs as suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: assertion failed: !ty.has_non_region_infer()
4 participants