Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fix spelling issues #136054

Closed
wants to merge 5 commits into from
Closed

Docs fix spelling issues #136054

wants to merge 5 commits into from
+7 −7

Conversation

nnsW3
Copy link

@nnsW3 nnsW3 commented Jan 25, 2025

Hello
I fixed several spelling issues.
Glad I could help
Br, Elias.

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BoxyUwU (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2025
@ChrisDenton
Copy link
Member

Please squish your commits into one.

klensy
klensy reviewed Jan 25, 2025
View reviewed changes
compiler/rustc_abi/src/layout.rs
// Don't try to calculate an end-biased layout for unsizable structs,
// Don't try to calculate an end-biased layout for unseizable structs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong?

jieyouxu
jieyouxu reviewed Jan 25, 2025
View reviewed changes
compiler/rustc_abi/src/layout/ty.rs
/// Provides various type traversal APIs (e.g., recursing into fields).
/// Provides various types of traversal APIs (e.g., recursing into fields).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is also wrong?

@jieyouxu
Copy link
Member

Based on the fact that some of these typo fixes seem wrong, and the fact that we've seen a wave of tiny fix PRs similar to yours that we suspect are linked with blockchain rewards, I'm going to close this PR. These sometimes result in github deleting the entire account and all PRs of that account, causing trouble for tooling processing commits and corresponding PRs. To avoid encouraging such PRs and to prevent churn from deleted PRs we will not accept such PRs. If you would like to contribute to the project, you are more than welcome to contribute something more substantial.

@jieyouxu jieyouxu closed this Jan 25, 2025
cuviper
cuviper reviewed Jan 25, 2025
View reviewed changes
compiler/rustc_abi/src/extern_abi/mod.rs
@@ -62,7 +62,7 @@ pub enum ExternAbi {
/// normally ABI-compatible Rust types can become ABI-incompatible with this ABI!
Unadjusted,
/// For things unlikely to be called, where reducing register pressure in
/// `extern "Rust"` callers is worth paying extra cost in the callee.
/// `extern "Rust"` callers are worth paying an extra cost in the callee.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is correct, "reducing register pressure (in ...) is"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

@klensy klensy klensy left review comments

@cuviper cuviper cuviper left review comments

Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nnsW3 @rustbot @ChrisDenton @jieyouxu @cuviper @klensy @BoxyUwU