Implement MIR const trait stability checks #136055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-ovmyztlkptmk
branch
from
7081449 to
65c9b8a
Compare
RalfJung
reviewed
Jan 25, 2025
fee1-dead
force-pushed
the
push-ovmyztlkptmk
branch
2 times, most recently
from
085a10a to
9737061
Compare
|
Looks like we do not have a test triggering const_eval_unmarked_const_item_exposed on a trait? The diff shows only one test change from that message change, for a regular fn call. |
I just added it. |
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-ovmyztlkptmk
branch
from
f1081ef to
d250657
Compare
|
LGTM, thanks! @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
…k, r=RalfJung Implement MIR const trait stability checks Addresses rust-lang/project-const-traits#16 cc `@rust-lang/project-const-traits` r? `@RalfJung`
This was referenced Jan 28, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135869 (Make docs for AtomicUsize::from_mut platform-independent) - rust-lang#135892 (-Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature`) - rust-lang#136055 (Implement MIR const trait stability checks) - rust-lang#136066 (Pass spans to `perform_locally_in_new_solver`) - rust-lang#136071 ([Clippy] Add vec_reserve & vecdeque_reserve diagnostic items) - rust-lang#136124 (Arbitrary self types v2: explain test.) - rust-lang#136149 (Flip the `rustc-rayon`/`indexmap` dependency order) - rust-lang#136173 (Update comments and sort target_arch in c_char_definition) - rust-lang#136178 (Update username in build helper example) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
Rollup merge of rust-lang#136055 - fee1-dead-contrib:push-ovmyztlkptmk, r=RalfJung Implement MIR const trait stability checks Addresses rust-lang/project-const-traits#16 cc ``@rust-lang/project-const-traits`` r? ``@RalfJung``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rust-lang/project-const-traits#16
cc @rust-lang/project-const-traits
r? @RalfJung