Rollup of 6 pull requests #136119
Closed
Rollup of 6 pull requests #136119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal: Move dual blanket impl logic from source analyzer to goto_def
This time, when completing the keyword (e.g. `fn` + whitespace). The bug was actually a double-bug: First, we did not resolve the impl in the macro-expanded file but in the real file, which of course cannot work. Second, in analysis the whitespace was correlated with the `impl` and not the incomplete `fn`, which caused fake (where we insert an identifier after the whitespace) and real expansions to go out of sync, which failed analysis. The fix is to skip whitespaces in analysis.
fix: Only refresh syntax tree view when the active document changes
fix: Fix missing upmapping in trait impls completion
internal: Cleanup `Name` string rendering
Goto `Display::fmt` when invoked on `to_string`
…t don't I don't think my ranking is perfect, because it places them even behind snippet completions, but this is something.
fix: Sort completion items that skip `await` and `iter()` behind those that don't
If the user doesn't have rustc on $PATH, rust-analyzer won't be able to run `rustc --print cfg`. This isn't really an error, as rust-analyzer can still proceed without it. This is particularly noticeable when loading crates defined in a rust-project.json. Until the configuration is loaded, the opened files are briefly treated as detached files and users see this error. Environments with rust-project.json generally have a sysroot and rustc elsewhere, so the error confuses users.
Ensure that all the fields that rust-analyzer understands are in the manual, they all have doc comments, and they use consistent punctuation (`;` rather than mixing `,` and `;`). Whilst we're here, fix the `sysroot_src` example and add 2024 as a legal value for Rust edition.
manual: Document all rust-project.json fields
The limit was introduced in rust-lang/rust-analyzer#1408 (comment) to avoid infinite cycles but it effectively caps the number of derefs to 10. Types like `ID3D12Device14` from the `windows` crate run into this because it derefs to `ID3D12Device13`, 13 to 12 and so on. Increasing it to 20 is a quick fix; a better cycle detection method would be nicer long term.
increase `AUTODEREF_RECURSION_LIMIT` to 20
This needs more time to bake before we turn it on. Turning it on early risks people silencing the warning indefinitely, before we have the chance to make it less noisy.
fix doc for std::sync::mpmc fix document of `std::sync::mpmc` (tracked in rust-lang#126840)
…jieyouxu Fix 2/4 tests skipped by opt-dist The linker errors were because this one test, strangely, wants itself compiled with `-Ctarget-features=+crt-static`, and yet it looks like the runner image is simply missing static libraries for libc and libm. Eyeballing the output of ``` rustc +nightly --target=x86_64-pc-windows-msvc -O tests/codegen/vec-shrink-panik.rs --emit=llvm-ir ``` suggests that vec-shrink-panik should pass on Windows. And it's quite disturbing that such a test would have failed only on Windows to start with. Exactly why that was would require some advanced digging, but it looks clean now.
Mark all NuttX targets as tier 3 target and support the standard library The support for standard library added by rust-lang#130595.
Downgrade `linker-warnings` to allow-by-default This needs more time to bake before we turn it on. Turning it on early risks people silencing the warning indefinitely, before we have the chance to make it less noisy. cc rust-lang#136096 fixes rust-lang#136086 (comment) r? `@saethlin` cc `@Noratrieb` `@bjorn3` `@rustbot` label A-linkage L-linker_messages
Miri subtree update r? `@ghost`
Subtree update of `rust-analyzer` r? `@ghost`
rustbot
added
A-run-make
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#135876 (fix doc for std::sync::mpmc) - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist) - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) - rust-lang#136098 (Downgrade `linker-warnings` to allow-by-default) - rust-lang#136110 (Miri subtree update) - rust-lang#136117 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#135876 (fix doc for std::sync::mpmc) - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist) - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) - rust-lang#136098 (Downgrade `linker-warnings` to allow-by-default) - rust-lang#136110 (Miri subtree update) - rust-lang#136117 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
linker-warningsto allow-by-default #136098 (Downgradelinker-warningsto allow-by-default)rust-analyzer#136117 (Subtree update ofrust-analyzer)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup