Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types #136311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types #136311

wants to merge 1 commit into from
+47 −5

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jan 30, 2025 •
edited
Loading

Check for impossible obligations in the dyn Trait type we're trying to compute its the vtable upcasting and method call slots.

r? lcnr

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2025
@bors
Copy link
Contributor

bors commented Jan 31, 2025

☔ The latest upstream changes (presumably #135318) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 31, 2025

⌛ Trying commit 9310860 with merge 13359cb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@bors
Auto merge of rust-lang#136311 - compiler-errors:vtable-fixes-2, r=<try>
13359cb 
Ensure that we never try to monomorphize the upcasting of impossible dyn types

Just the last commit, blocked on rust-lang#135318.

r? lcnr
@compiler-errors compiler-errors changed the title Ensure that we never try to monomorphize the upcasting of impossible dyn types Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types Jan 31, 2025
@compiler-errors
Copy link
Member Author

compiler-errors commented Jan 31, 2025 •
edited
Loading

Ok, I removed the impossible_predicates check for the vtable_entries call. I don't think that one is necessary (at least not for this ICE) b/c we should've actually checked this during unsizing. Checking locally, this seems to make fuchsia build 👍.

@compiler-errors compiler-errors marked this pull request as ready for review January 31, 2025 18:44
@steffahn steffahn mentioned this pull request Feb 3, 2025
Open
@lcnr
Copy link
Contributor

lcnr commented Feb 3, 2025

r=me after perf :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compiler-errors @bors @lcnr @rustbot