-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure triagebot to accept codegen-{gcc,cranelift} ping groups and document ping groups and ping commands #138120
base: master
Are you sure you want to change the base?
Conversation
@rustbot blocked (rust-lang/team#1685) |
I'm probably going to not add those aliases (more ways to do the same thing becomes even more confusing). |
344cff3
to
1ae5bb0
Compare
I dropped the aliases to avoid more ways to do the same thing to avoid it getting more confusing. |
The name seems inconsistent with the LLVM backend ping group which is |
@RalfJung you also fell for the classic "llvm" ping group trap 😆
|
https://rustc-dev-guide.rust-lang.org/notification-groups/llvm.html doesn't say it has anything to do with icebreakers. Was the meaning of that name changed at some point? |
Possibly, but that might've been a while ago |
Blocked on rust-lang/team#1685.
Discussion: #t-infra > Triagebot ping groups for GCC and cranelift backends.
Closes #138116.
r? ghost