Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure triagebot to accept codegen-{gcc,cranelift} ping groups and document ping groups and ping commands #138120

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Mar 6, 2025

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@jieyouxu jieyouxu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 6, 2025

@rustbot blocked (rust-lang/team#1685)

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 6, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 6, 2025

I'm probably going to not add those aliases (more ways to do the same thing becomes even more confusing).

@jieyouxu jieyouxu force-pushed the cg_backend_ping_groups branch from 344cff3 to 1ae5bb0 Compare March 8, 2025 01:37
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 8, 2025

I dropped the aliases to avoid more ways to do the same thing to avoid it getting more confusing.

@RalfJung
Copy link
Member

RalfJung commented Mar 10, 2025

The name seems inconsistent with the LLVM backend ping group which is @rustbot ping llvm (not codegen-llvm).

@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 10, 2025

@RalfJung you also fell for the classic "llvm" ping group trap 😆

It is not. llvm is an alias for llvm icebreakers ping group, see

https://github.com/rust-lang/rust/blob/master/triagebot.toml#L48-L49

this was brought up in wg-llvm zulip thread before since I've made this same mistake of thinking llvm pings wg-llvm (that we should retire the icebreakers ping group and redirect llvm to ping wg-llvm)

-- #138120 (comment)

@RalfJung
Copy link
Member

RalfJung commented Mar 10, 2025

https://rustc-dev-guide.rust-lang.org/notification-groups/llvm.html doesn't say it has anything to do with icebreakers. Was the meaning of that name changed at some point?

@jieyouxu
Copy link
Member Author

Possibly, but that might've been a while ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for setting up codegen backend ping groups
4 participants