-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support XDG_CONFIG_HOME for configuration file on macOS #6181
base: master
Are you sure you want to change the base?
Conversation
3d42076
to
1a6294a
Compare
1a6294a
to
547d61c
Compare
547d61c
to
b2a6982
Compare
I took a quick look at the dirs README and the dirs code, and both seem to suggest that |
Oh wait, that's just for linux. Reopening. |
@heygarrett we've had issues in the past where users have reported configs not being loaded properly. To avoid any breakage due to the proposed switch to In the past I tried adding tests for the config loading rules, though I'm not entirely sure if that old PR is the best approach for this. Maybe you can use it as inspiration though. |
Thanks, @ytmimi! I'll take a look. |
Fixes #4613
Replacing dirs with etcetera adds support for checking XDG_CONFIG_HOME on macOS when looking for a configuration file.
I'm new to Rust, so let me know if I'm missing anything!