Suppress warning if max_width reduced below other settings in macro #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning makes sense at the top level because it indicates a user misconfiguration, but the warning can also fire when a macro reduces max_width within its scope, which is confusing. We can plumb a flag through saying whether to warn or not and have the macro-related twiddling disable the warning, which will still be on at the top level.
|
@rs-sac I don't think suppressing the warning is the approach we should take here. I think it would be better to clap all other width settings to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning makes sense at the top level because it indicates a user misconfiguration, but the warning can also fire when a macro reduces max_width within its scope, which is confusing. We can plumb a flag through saying whether to warn or not and have the macro-related twiddling disable the warning, which will still be on at the top level.
This change allows setting, e.g., struct_lit_width to the same value as max_width without getting incorrect warnings within macro scopes. The bug related to macros has been previously acknowledged, and a previous fix was attempted. I attempt to fix the same problem, but my patch takes an approach different from deleting the warning.
Related:
max_width = 100(issue #5404)