Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect separator for match arms (#6373) #6376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfarberbrodsky
Copy link

Fixes #6373

The post_comment member of the ListItem corresponding to the first match arm in the test contained the trailing comma, even though it should have been trimmed.
The reason it wasn't trimmed is that the separator for the match arms list was pipe | rather than comma ,.

@ytmimi
Copy link
Contributor

ytmimi commented Oct 28, 2024

Thanks for the PR. Can you add some additional test cases where the match arms aren't separated by commas. For example, when each arm has a block body.

@calebcartwright
Copy link
Member

and also some where the arm patterns have leading pipes (with match_arm_leading_pipes configured to add/preserve pipes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block comment inside match adds unnecessary comma
4 participants