Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launching-pad team. #1206

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add launching-pad team. #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3441305
Add launching-pad team.
ehuss Jan 14, 2024
805a272
Set parent team for wg-triage.
ehuss Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,6 @@ fn validate_subteam_of(data: &Data, errors: &mut Vec<String>) {
);
};

if !matches!(team.kind(), TeamKind::Team) && parent.subteam_of().is_some() {
bail!(
"{} `{}` can't be a subteam of a subteam (`{}`)",
team.kind(),
team.name(),
parent.name(),
);
}

Comment on lines -188 to -196
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't 100% understand why this clause was left in #1046. @fmease Can you say why this is here?

Copy link
Member

@fmease fmease Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't get notified by the ping, maybe because this PR is marked as a draft? I saw this PR just now since I'm subscribed to this repo.

Copy link
Member

@fmease fmease Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this check because it's not clear where to place WGs and PGs that are children of subteams on the website. Today, WGs and PGs are placed at the bottom of the page in distinct sections. It doesn't feel right to place WGs/PGs that aren't actually direct children of the team whose page we are looking at at the same level as other WGs/PGs especially since the user wouldn't necessarily be able to draw a connection between a given group and the respective parent team.

Copy link
Member

@fmease fmease Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example:

Team A
+-- Team A-A
|   +-- Working Group A-A-A
+-- Team A-B

The webpage of team A would look like:

Team A
--- Subteams
Team A-A
Team A-B
--- WGs
Working Group A-A-A
--- PGs

Now it's unclear if WG A-A-A is a direct child of A, A-A or A-B (without looking at their names of course which might not reflect the hierarchy).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that for subsubteams (and sub^N-teams, N>2), I've made the website semi-preserve the hierarchy by walking the team structure in pre-order. The situation is slightly better since they're contained in the same section on the page.

team = parent;
}
Ok(())
Expand Down
1 change: 1 addition & 0 deletions teams/community.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "community"
subteam-of = "launching-pad"

[people]
leads = []
Expand Down
1 change: 1 addition & 0 deletions teams/docker.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "docker"
subteam-of = "launching-pad"

[people]
leads = []
Expand Down
7 changes: 7 additions & 0 deletions teams/launching-pad.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
name = "launching-pad"

[people]
# This is an "umbrella" team, and thus does not have any members.
leads = []
members = []
alumni = []
1 change: 1 addition & 0 deletions teams/twir.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "twir"
subteam-of = "launching-pad"

[people]
leads = ["nellshamrell"]
Expand Down
1 change: 1 addition & 0 deletions teams/web-presence.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "web-presence"
subteam-of = "launching-pad"

[people]
leads = []
Expand Down
1 change: 1 addition & 0 deletions teams/wg-async.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-async"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-cli.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-cli"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-embedded.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-embedded"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-gamedev.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-gamedev"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-rust-by-example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-rust-by-example"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-secure-code.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-secure-code"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-security-response.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-security-response"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-triage.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name = "wg-triage"
kind = "working-group"
subteam-of = "launching-pad"

[people]
leads = ["Dylan-DPC"]
Expand Down
1 change: 1 addition & 0 deletions teams/wg-wasm.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name = "wg-wasm"
subteam-of = "launching-pad"
kind = "working-group"

[people]
Expand Down