Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable new PR assignment, just log #1893

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

apiraino
Copy link
Contributor

Following discussion on Zulip, I am going to disable the new PR assignment and just log its behaviour.

r? @Kobzol

cc @jackh726

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apiraino I'm assuming we didn't hit an expect or something because that would have been logged, right?

@apiraino apiraino force-pushed the disable-new-pr-assignment branch from 541ebe2 to a8d9f35 Compare January 27, 2025 13:00
@apiraino
Copy link
Contributor Author

apiraino commented Jan 27, 2025

@apiraino I'm assuming we didn't hit an expect or something because that would have been logged, right?

Yes, the only important expect I can see here is if the DB query fails being run (which would be a bigger issue).

(The triagebot logs are visible up to INFO level, so they just exclude DEBUG, iiuc)

@jackh726 jackh726 merged commit 0b5ed11 into rust-lang:master Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants