Skip to content

Commit

Permalink
Add a comment explaining the correct way to add new NIF API functions
Browse files Browse the repository at this point in the history
  • Loading branch information
filmor committed Aug 5, 2024
1 parent f2b1522 commit fcd7faa
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions rustler_sys/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,12 @@ fn build_api(b: &mut dyn ApiBuilder, opts: &GenerateOptions) {
"env: *mut ErlNifEnv, opt: ErlNifOption",
);
}

// If new functions are added for a new OTP version, ensure that *all* functions are added in
// the *correct order*. Failure to do so will result in errors on Windows, as the callback
// handling uses the `TWinDynNifCallbacks` struct.
//
// The correct order can (currently) by derived from the `erl_nif_api_funcs.h` header.
}

fn get_nif_version_from_features() -> (u32, u32) {
Expand Down

0 comments on commit fcd7faa

Please sign in to comment.