Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): Add lock command #1066

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(commands): Add lock command #1066

wants to merge 3 commits into from

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Feb 16, 2024

This PR adds new commands to lock (parts of) the repository:

  • lock repository to lock the complete repository. This can invalidate update/remove operations; it is suggested to use feat: Add append-only repository mode rustic_core#164 to mark the repository append-only before doing this!
  • lock keys to lock all keys. This can invalidate key removal.
  • lock snapshots to lock snapshots and needed pack files. This also sets an mark to the snapshots/pack files such that

see #1050

depends on rustic-rs/rustic_core#163

Also fixes the handling of delete-protected snapshots in the forget command when snapshots are explicitly given

TODO:

  • remove temporary Cargo.toml change once the above PR is merged into rustic_core
  • Maybe add more options to specify the "until when" timestamp. e.g. a alternative --until option.
  • Think about whether we want to require to have append-only mode for lock repository.
  • Think about a similar mechanism only for keys to lock
  • Maybe add possibility to only lock given keys

@simonsan simonsan added the S-blocked Status: Blocked from merging/working on due to some issue label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked from merging/working on due to some issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants