Adjust for changes to osm2pgsql RE replication initialization #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustprooflabs
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following osm2pgsql-dev/osm2pgsql#2212, RE #392.
Add related documentation for how to do this testing, and that replication is not being tested by the makefile.
Removes test broken by
osm2pgsql#2212. The removed test only validated the initial setup of replication, not more complicated bits.osm2pgsqlnow raises an error when the file is too old (because it can't possibly update from it), which is a good thing.If someone in the future wants to suggest an effective approach to testing the replication functionality, feel free submit an issue or PR!