Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve ergonomics of fn replace #250

Merged
merged 1 commit into from
Oct 18, 2023
Merged

refactor: improve ergonomics of fn replace #250

merged 1 commit into from
Oct 18, 2023

Commits on Oct 18, 2023

  1. refactor: improve ergonomics of fn replace 

    After trialing `replace_(imported|exported)_func` in WASI-Virt, it's clear
that the ergonomics around the builder function need to be
improved. `FunctionBuilder` (particularly `FunctionBuilder::new()` is
difficult to use without a mutable borrow of the module itself.

This commit refactors `replace_(imported|exported)_func` in order to
pass through the mutable borrow which makes it easier to use
`FunctionBuilder`s.

Signed-off-by: Victor Adossi <[email protected]>
    @vados-cosmonic
    vados-cosmonic committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f74b185 View commit details
    Browse the repository at this point in the history