fix: disable multi-memory when config.only_stable_features is true #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssemly features/proposals
This PR overhauls how
config.only_stable_featuresis translated towasmparser::WasmFeatures.Now, when
only_stable_features == true, only stable features (finished proposals) will be enabled.In default mode (
only_stable_features == false), all supported features will be enabled.Currently, only
multi-memoryfeature is fully supported.threadfeature needs to be enabled because of a round_trip test.The skipped tests in non-proposals spec-tests are all removed. Therefore,
walruswithonly_stable_features == trueconforms the current WebAssembly standard.Other
Also upgrades dependencies in
fuzz-utilscrate.