Skip to content

Commit

Permalink
Remove group imports format checking
Browse files Browse the repository at this point in the history
It makes too many suboptimal choices for now.

See
rust-lang/rustfmt#5083 (comment)
and
rust-lang/rustfmt#5083 (comment)
  • Loading branch information
jonhoo committed Feb 18, 2024
1 parent 80749d4 commit 6c98127
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
17 changes: 0 additions & 17 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,6 @@ jobs:
components: rustfmt
- name: cargo fmt --check
run: cargo fmt --check
# This is currently a dedicated job due to the rustfmt's `group_imports` configuration
# option being available on the nightly channel only as of February 2024.
# Once stabilized, can be merged with the `stable / fmt` job in this workflow.
# See: https://github.com/rust-lang/rustfmt/issues/5083
imports:
runs-on: ubuntu-latest
name: nightly / fmt (import grouping)
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install nightly
uses: dtolnay/rust-toolchain@nightly
with:
components: rustfmt
- name: cargo +nightly fmt -- --config group_imports=one --check
run: cargo +nightly fmt -- --config group_imports=one --check
clippy:
runs-on: ubuntu-latest
name: ${{ matrix.toolchain }} / clippy
Expand Down
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ check:
cargo fmt --check
cargo clippy
cargo d --no-deps --all-features
cargo +nightly fmt -- --config group_imports=one --check

.PHONY: doc
doc:
Expand Down Expand Up @@ -36,10 +35,6 @@ faktory/tls:
faktory/tls/kill:
docker compose -f docker/compose.yml down

.PHONY: sort
sort:
cargo +nightly fmt -- --config group_imports=one

.PHONY: test
test:
cargo t --locked --all-features --all-targets
Expand Down

0 comments on commit 6c98127

Please sign in to comment.