add data-trunk8-* support #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -226,8 +226,18 @@ | |||
| if (!data) { | |||
| $this.data('trunk8', (data = new trunk8(this))); | |||
| } | |||
|
|
|||
| // add data-trunk8-* support | |||
| var elAttr = {}; | |||
There was a problem hiding this comment.
Prefer verbose name "elementAttributes"
|
@rviscomi thanks for your reply,and i have add a new commit to fix the problem. |
merge from the autor
| @@ -226,6 +226,8 @@ | |||
|
|
|||
| methods = { | |||
| init: function (options) { | |||
| // data-trunk8-* config prefix | |||
| var trunk8DataAttributeName = 'data-trunk8-'; | |||
There was a problem hiding this comment.
This should be moved into the return function with the other vars (elementAttributes, attributes).
format the script
|
thanks @rviscomi i learn much more than the code itself ~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add attribute data-trunk8-* to each element for special settings
@rviscomi sorry for my english,i am uncertain if i understand your words
the order of the config is :
trunk8.defaults -- trunk8 config -- element attribute
and the next will override the last