Iss119 #120
Open
Iss119 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwijtvliet
reviewed
Jan 20, 2025
| @@ -227,6 +227,7 @@ def assert_index_standardized(i: pd.DatetimeIndex, __right: bool = False): | |||
| if tools_freq.up_or_down(freq, "D") > 0: | |||
| if freq == "MS": | |||
| period, not_ok = "month", ~i.is_month_start | |||
| # ATTN!: again, this now wouldn't work as expected | |||
There was a problem hiding this comment.
If the comment applies to the QS and YS case, then de-indent it one level please
rwijtvliet
approved these changes
Jan 20, 2025
not really, attn comments are more to show that this line was changed and there were no tests for this function (where the comment is) with new freq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to the issue 119: #119
changed functions in tools.isboundary.py to work with both objects and strings for frequencies
changes and notes can be found with ATTN!
📚 Documentation preview 📚: https://portfolyo--120.org.readthedocs.build/en/120/