Pandas fix #99
Merged
Pandas fix #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commented out problematic script
rwijtvliet
reviewed
Jul 30, 2024
portfolyo/tools/unit.py
Outdated
| # Convert all values to same unit. | ||
| units = fr.values[0].units | ||
| magnitudes = [v.to(units).magnitude for v in fr.values] | ||
| return pd.Series(magnitudes, fr.index, dtype=f"pint[{units}]") |
There was a problem hiding this comment.
There is actually a much easier way to convert a series of objects into a pint-series, if possible:
portfolyo/tools/freq.py
Outdated
| @@ -9,7 +9,7 @@ | |||
|
|
|||
|
|
|||
| # Allowed frequencies. | |||
| ALLOWED_FREQUENCIES_DOCS = "'15T' (=quarterhour), 'H', 'D', 'MS', 'QS' (or 'QS-FEB', 'QS-MAR', etc.), or 'AS' (or 'AS-FEB', 'AS-MAR', etc.)" | |||
| ALLOWED_FREQUENCIES_DOCS = "'15T' (=quarterhour), 'H', 'D', 'MS', 'QS' (or 'QS-FEB', 'QS-MAR', etc.), or 'YS' (or 'AS-FEB', 'AS-MAR', etc.)" | |||
rwijtvliet
reviewed
Jul 31, 2024
docs/specialized_topics/dataprep.rst
Outdated
| @@ -71,7 +71,7 @@ Frequency | |||
|
|
|||
| The index must have a frequency (``fr.index.freq``) and it must be a valid frequency. To check validity of the frequency, one may use ``portfolyo.assert_freq_valid()``. The following abbreviations are used by ``pandas`` and throughout this package: | |||
|
|
|||
| * ``15T``: quarterhourly; | |||
| * ``15min``: quarterhourly; | |||
| * ``H``: hourly; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
oi, you meant 'H'
also, yes
rwijtvliet
reviewed
Jul 31, 2024
portfolyo/core/pfstate/pfstate.py
Outdated
| The frequency at which to resample. 'AS' for year, 'QS' for quarter, 'MS' | ||
| (default) for month, 'D for day', 'H' for hour, '15T' for quarterhour. | ||
| The frequency at which to resample. 'YS' for year, 'QS' for quarter, 'MS' | ||
| (default) for month, 'D for day', 'H' for hour, '15min' for quarterhour. |
There was a problem hiding this comment.
@Pizza2Pizza: should 'H' be 'h'?
rwijtvliet
reviewed
Jul 31, 2024
portfolyo/tools/freq.py
Outdated
| @@ -251,8 +251,8 @@ def longest(*freqs: str) -> str: | |||
|
|
|||
| Examples | |||
| -------- | |||
| >>> freq.longest('MS', 'H', 'AS', 'D') | |||
| 'AS' | |||
| >>> freq.longest('MS', 'H', 'YS', 'D') | |||
rwijtvliet
reviewed
Jul 31, 2024
portfolyo/tools/freq.py
Outdated
| @@ -231,7 +231,7 @@ def shortest(*freqs: str) -> str: | |||
|
|
|||
| Examples | |||
| -------- | |||
| >>> freq.shortest('MS', 'H', 'AS', 'D') | |||
| >>> freq.shortest('MS', 'H', 'YS', 'D') | |||
rwijtvliet
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated versions of pandas, pint and pint-pandas:
pandas = "^2.0"
pint = "^0.24"
pint-pandas = "0.6"
Updated functions due to internal changes of pint-pandas that distinguish between pandas Series with object data type and one with pint units
📚 Documentation preview 📚: https://portfolyo--99.org.readthedocs.build/en/99/