add GetBestPtCheckpointJob #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackTemaki
requested changes
Jul 25, 2023
JackTemaki
requested changes
Jul 25, 2023
Right. In this case, the code duplication is also reduced, so we can just add the torch specific job imho. |
JackTemaki
approved these changes
Jul 25, 2023
michelwi
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the
GetBestTFCheckpointJoband I'd like to add the equivalent for torch checkpoints. I added a very similarGetBestPtCheckpointJobsince this does not interfere with existing setups. We might also think about how to avoid some of the code duplications, but this seems to be the simplest solution.