Add rounding scheme rasr_compatible #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelwi
requested review from
christophmluscher,
JackTemaki,
Icemole,
SimBe195,
vieting and
Atticus1806
vieting
approved these changes
Jul 26, 2023
Co-authored-by: vieting <[email protected]>
christophmluscher
approved these changes
Jul 31, 2023
christophmluscher
deleted the
willi-make-BlissToPcmHDFJob-RASR-compatible
branch
Atticus1806
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Add rounding scheme rasr_compatible * Update returnn/hdf.py Co-authored-by: vieting <[email protected]> --------- Co-authored-by: vieting <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that RASR and the
BlissToPcmHDFJobuse different rounding methods when the start/end time in the corpus does not coincide exactly with a sample. This might in a few cases lead to a different number of frames for features and alignments and break the training.This implements a rounding scheme that I believe is compatible with RASR.