Onnx Feature Scorer

[Marvin84]

Starting with the apptek version, I renamed some variables in order to decouple this from the old GMM feature scorer. Moreover, 2 internal rasr variables with their default values are added.

The outdated wrong FH label scorer should be deleted.

[Atticus1806]

I thought this PR was about adding a new feature scorer not replacing and old?

Also I think rasr is not defined.

[christophmluscher]

I agree with @Atticus1806 we should add a Featurescorer not replace

Or is the tf label scorer removed from RASR code?

[christophmluscher]

I would add onnx feature scorer and later refactor the FH label scorer

[Marvin84]

I thought this PR was about adding a new feature scorer not replacing and old?

I would add onnx feature scorer and later refactor the FH label scorer

We discussed this some time ago and I wondered why this FS is still there. The code that is here would not work in any setup or branch of rasr. First of all, this is an outdated FH FS and has ended up in this module only by error. Secondly, the merging of the 24bit now we can have FH in the master of rasr however, there is still no feature scorer in the master. Therefore, this code should be deleted.

[Marvin84]

I agree with @Atticus1806 we should add a Featurescorer not replace

Or is the tf label scorer removed from RASR code?

It has never been in the master version. This is from 4 years ago. Refactoring it would not bring anything since the new FS is completely different

[JackTemaki]

some small things

[Atticus1806]

If its deprecated and all tests pass I am not against removing, I don't know the details I just noticed that this was different from what I expected :).

Just make sure with AppTek I guess (do their tests claim completeness? If so I guess its fine if tests pass)

Once that is clear and the typing is changeed I think it can be approved :)

[Atticus1806]

Thanks :)

[curufinwe]

Just make sure with AppTek I guess (do their tests claim completeness? If so I guess its fine if tests pass)

We never used the deleted scorer, so it should be fine.
The tests we have cover almost everything that is related to the training / running of our production systems so if they are green you should be ok.

[curufinwe]

PS: the current failing check is because of this:

  File "test/hash_test/check_hashes.py", line 17, in <module>
    config_manager.load_configs([args.function])
  File "/opt/atlassian/pipelines/agent/build/.nox/check_hashes-3-8/lib/python3.8/site-packages/sisyphus/loader.py", line 114, in load_configs
    self.load_config_file(filename)
  File "/opt/atlassian/pipelines/agent/build/.nox/check_hashes-3-8/lib/python3.8/site-packages/sisyphus/loader.py", line 54, in load_config_file
    config = importlib.import_module(module_name)
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/opt/atlassian/pipelines/agent/build/config/create_corpora.py", line 2, in <module>
    from apptek_asr.data.common import BuildCorpusFromCSV, BuildCorpusFromBliss
  File "/opt/atlassian/pipelines/agent/build/apptek_asr/data/common/__init__.py", line 1, in <module>
    from .build_corpus import *
  File "/opt/atlassian/pipelines/agent/build/apptek_asr/data/common/build_corpus.py", line 27, in <module>
    from i6_core.corpus import (
  File "/opt/atlassian/pipelines/agent/build/i6_core/corpus/__init__.py", line 2, in <module>
    from .costa import *
  File "/opt/atlassian/pipelines/agent/build/i6_core/corpus/costa.py", line 5, in <module>
    from i6_core.features.common import raw_audio_flow
  File "/opt/atlassian/pipelines/agent/build/i6_core/features/__init__.py", line 1, in <module>
    from .common import *
  File "/opt/atlassian/pipelines/agent/build/i6_core/features/common.py", line 18, in <module>
    import i6_core.rasr as rasr
  File "/opt/atlassian/pipelines/agent/build/i6_core/rasr/__init__.py", line 3, in <module>
    from .feature_scorer import *
  File "/opt/atlassian/pipelines/agent/build/i6_core/rasr/feature_scorer.py", line 19, in <module>
    from typing import Union, Dict, Bool
ImportError: cannot import name 'Bool' from 'typing' (/usr/local/lib/python3.8/typing.py)

[Marvin84]

PS: the current failing check is because of this:

Yes, solved

[Marvin84]

@curufinwe I give you all passed tests and 3 approvals, do I get a merge from you? :)

[NeoLegends]

Nice