Drop optional CTM n-best header #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optional header fields leads to issues in GLM mapping leading to high (almost 100 percent) deletion rates, because all lines with fewer than 7 columns are dropped from the file.
NeoLegends
requested review from
albertz,
curufinwe,
christophmluscher,
michelwi and
Stefanwuu
michelwi
approved these changes
Sep 11, 2024
|
Just to clarify: Can you explain why this was not an issue so far? Because we usually don't do GLM mapping? |
albertz
reviewed
Sep 11, 2024
The "bug" is - I think - in the AppTek scoring pipeline where we recently started to use the number of fields in the header to discard "invalid" lines in the CTM which do not have the correct number of fields. So far this was not an issue because no one would use the ctm outputs of this job with the AppTek scoring pipeline and the AppTek asr pipeline would not print this optional field in the header. |
|
Ok, then I would mention exactly that in a code comment. But in any case, I think the code change is otherwise ok then. |
albertz
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optional header fields leads to issues in GLM mapping, resulting in high (almost 100 percent) deletion rates, because all lines with fewer than 7 columns are dropped from the file.