Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DelayedBase parameter in WriteToTextFileJob #546

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Allow DelayedBase parameter in WriteToTextFileJob #546

merged 3 commits into from
Nov 8, 2024

Conversation

BenediktConze
Copy link
Contributor

Properly handle the content parameter of WriteToTextFileJob if it derives from DelayedBase.

@michelwi
Copy link
Contributor

michelwi commented Oct 7, 2024

Instead of adding another case, could we use

content = instanciate_delayed(self.content)

and then list and dicts of DelayedBase are also immediately supported?

@BenediktConze
Copy link
Contributor Author

Good point, I changed it.

Atticus1806
Atticus1806 approved these changes Oct 8, 2024
View reviewed changes
text/processing.py Outdated Show resolved Hide resolved
@Marvin84 Marvin84 merged commit dca8f09 into main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atticus1806 Atticus1806 Atticus1806 approved these changes

@michelwi michelwi michelwi approved these changes

@christophmluscher christophmluscher Awaiting requested review from christophmluscher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenediktConze @michelwi @Atticus1806 @Marvin84