Even kernel size for pooling layers in the GenericFrontend not permitted

[kuacakuaca]

i6_models/i6_models/parts/frontend/generic_frontend.py

Line 88 in 3c91736

for kernel_sizes in filter(None, [self.conv_kernel_sizes, self.pool_kernel_sizes]):

[albertz]

What is this issue about? You think this is a problem that even kernel sizes are not permitted? So you want to change that?

[kuacakuaca]

What is this issue about? You think this is a problem that even kernel sizes are not permitted? So you want to change that?

I want to use even kernel size for the pooling layers, is there any reason we don’t want to allow this?

[albertz]

As far as I remember, there were technical reasons why it did not work. (I actually was against having the check here at that point, because this makes it unclear why it was not allowed. Just trying it out shows the problem much more clearly.) Maybe it's actually not a problem anymore in a more recent PyTorch version? I don't know. Just try it out.

[JackTemaki]

I think the limitation (from PyTorch side) was only for Convolution with "padding=same"...

[kuacakuaca]

thanks! I'll just try.