Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply minor fixes to GenericFrontend code #62

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

SimBe195
Copy link
Contributor

@SimBe195 SimBe195 commented Nov 5, 2024

This fixes some minor bugs in the GenericFrontendV1 class.

  1. Permit even pool kernel sizes (also discussed in Even kernel size for pooling layers in the GenericFrontend not permitted #50). Odd kernel sizes were only a problem for convolution modules and even pool kernel sizes like 2 have worked fine in testing.
  2. conv_stride is supposed to be a tuple so the default value of 1 if model_cfg.conv_strides is None is wrong.
  3. If pool_stride is set to None, then the expression pool_stride[1] or pool_kernel_size[1] results in an error. pool_stride[1] should only be accessed if pool_stride is not None.

@SimBe195 SimBe195 merged commit e22c46a into main Nov 6, 2024
2 checks passed
@SimBe195 SimBe195 deleted the generic_frontend_fixes branch November 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants