Skip to content

Commit

Permalink
RF sinusoidal_positional_encoding, small fix for out shape check
Browse files Browse the repository at this point in the history
  • Loading branch information
albertz committed Feb 3, 2025
1 parent 9428130 commit ada4dd7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion returnn/frontend/attention.py
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,8 @@ def sinusoidal_positional_encoding(
arg, feat_dim_ = rf.replace_dim(arg, in_dim=feat_dim_, out_dim=feat_dim)
emb = rf.sin(arg)
emb.verify_out_shape(
{spatial_dim, feat_dim} if spatial_dim != single_step_dim else {feat_dim}, allow_missing_implicit_dims=True
{feat_dim} | indices.dims_set | ({spatial_dim} if spatial_dim != single_step_dim else set()),
allow_missing_implicit_dims=True,
)
emb.feature_dim = feat_dim
_sinusoidal_positional_encoding_cache.set(cache_key, emb)
Expand Down

0 comments on commit ada4dd7

Please sign in to comment.