Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No job cleanup for symlinked job dirs #154

Merged
merged 3 commits into from
Nov 21, 2023
Merged

No job cleanup for symlinked job dirs #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e714a7
No job cleanup for symlinked job dirs
albertz Nov 20, 2023
546efb6
better, do not stat over and over
albertz Nov 20, 2023
e2090a2
fix, reverted the logic
albertz Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sisyphus/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,9 @@ def _sis_cleanable(self):
elif self._sis_cleanable_cache:
return True
else:
if os.path.islink(self._sis_path()):
self._sis_cleaned_or_not_cleanable = True
return False
cleanable = not os.path.isfile(self._sis_path(gs.JOB_FINISHED_ARCHIVE)) and self._sis_finished()
if cleanable:
self._sis_cleanable_cache = True
Expand Down
Loading