Fix worker proc hanging at exception #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all exceptions in Task.run will lead to logging_thread.stop(), which is required that the proc does not hang at exit, because logging_thread was not a daemon thread. We make it a daemon thread now. And also, we additionally make extra sure that logging_thread.stop() is called. (Although there are maybe still other rare cases where this is not effective, so the daemon thread property is still important as well.) Fix #171.
michelwi
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all exceptions in Task.run will lead to logging_thread.stop(), which is required that the proc does not hang at exit, because logging_thread was not a daemon thread.
We make it a daemon thread now.
And also, we additionally make extra sure that logging_thread.stop() is called.
(Although there are maybe still other rare cases where this is not effective, so the daemon thread property is still important as well.)
Fix #171.