-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job, possibility to update env vars #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on #178
I think putenv
should be named set_env
and I would avoid creating and compiling an extra file here and just update directly from _sis_environ_updates
.
It bothers me to introduce a new structure which changes the environment. How about always creating the EnvironmentModifier, but only clean the environment if That way you should be able to accomplish the same thing without updating the environment in two different places. |
I really don't want the |
Let's move the discussion to #178 to avoid two parallel discussions about the same thing. |
As it was discussed in #178.
Fix #178