refact(): removed a lot of logic related to copy packages folder rsyn…

…c is now gone and we are left with only npm resolutions

README.md

@@ -67,11 +67,26 @@ If the binaries don't work in `mac` or `windows` please install it via `npm` glo
 
 #### Usage
 
+Bootstrapping the packages
+It will run `npm install` inside the current working directory
+This will install local packages referenced inside `fireDependencies`
+It means that `node_modules` folder will be already populated with appropriate packages after `npm install`
+
+```bash
+firelink --bootstrap --no-runner
+```
+
+Deploying as usual
+
 ```bash
 firelink deploy
 ```
 
-The same as `firebase deploy` the only differance is that it will COPY monorepos replace package.json > dependencies with appropriate local file structure and then will revert changes after `firebase` script exit
+You can also use one liner replacement for `npm install` and `firebase deploy`
+
+```bash
+firelink deploy --bootstrap
+```
 
 #### Leave changes to package.json after command execution exited
 
@@ -133,50 +148,20 @@ Revert the changes made inside `package.json`
 firelink --no-runner --revert-changes
 ```
 
-#### Native Nodejs Copy instead of `rsync`
-
-This argument is introduced due to recent issue that has being made https://github.com/rxdi/firelink/issues/55
-It appears that in the newest nodejs 16 docker image rsync package is missing
-
-There is a way to specify which runner firelink will use
-when specify `--use-native-copy` it will default to nodejs implementation of recursive copy the files
-By default in windows environment this is the main method used to copy files since `rsync` is missing in windows
-
-```
-firelink --use-native-copy
-```
-
 # Configuration
 
 Default runner is command `firebase` but you can change it for example to `gcloud` or `serverless` by defining `fireConfig` inside `package.json`
 
 ```json
 {
   "fireConfig": {
-    "runner": "firebase",
-    "outFolderName": ".packages",
-    "outFolderLocation": ".",
-    "excludes": ["node_modules"],
-    "useNativeCopy": true
+    "runner": "firebase"
   }
 }
 ```
 
-`excludes` property can exclude some folders or files from being copied it accepts `Array` from `string`
-
-For example we may want to install dependencies of the packages when deploying using local npm path,
-so we want to not waste time duplicating node modules
-
-Equivalent of excludes inside package.json `.fireignore` can be specified as a file inside a directory where the command `firelink` will be executed. `.fireignore` behaviour is the same as `.gitignore`
-
-If you do not wish to use `.fireignore` file name the name can be specified from `fireConfig.excludesFileName`
-
 You can pass `--runner dir` argument to the command which will override the default runner `firebase`
 
-By default packages will be saved in `.packages` folder and `current` directory will be used
-U can change that by specifiyng properties `outFolderName` and `outFolderLocation` inside `fireConfig`
-Check `example` folder inside this repository
-
 You can put even `dir` command
 
 ```json

example/package.json

@@ -7,12 +7,6 @@
     "@test/dependency": "./packages/dependency"
   },
   "fireConfig": {
-    "runner": "npm",
-    "outFolderName": ".packages",
-    "outFolderLocation": ".",
-    "excludes": [
-      "node_modules"
-    ],
-    "useNativeCopy": true
+    "runner": "firebase"
   }
 }

package.json

@@ -42,4 +42,4 @@
     "ts-jest": "29.0.3",
     "typescript": "^4.8.4"
   }
-}
+}

src/create-virtual-symlink.spec.ts

@@ -2,7 +2,7 @@ import { createVirtualSymlink } from './create-virtual-symlink';
 import { PackageJson } from './injection-tokens';
 
 const mockBuildPackages = jest.fn();
-const mockCopyPackages = jest.fn();
+// const mockCopyPackages = jest.fn();
 const mockExitHandler = jest.fn();
 const mockModifyJson = jest.fn();
 const mockRevertJson = jest.fn();
@@ -11,15 +11,15 @@ const mockRunCommand = jest.fn();
 jest.mock('./helpers/build-packages', () => ({
   buildPackages: async (...args: unknown[]) => mockBuildPackages(...args),
 }));
-jest.mock('./helpers/copy-packages', () => ({
-  copyPackages:
-    (...args: unknown[]) =>
-    () =>
-    () =>
-    () =>
-    () =>
-      mockCopyPackages(...args),
-}));
+// jest.mock('./helpers/copy-packages', () => ({
+//   copyPackages:
+//     (...args: unknown[]) =>
+//     () =>
+//     () =>
+//     () =>
+//     () =>
+//       mockCopyPackages(...args),
+// }));
 jest.mock('./helpers/exit-handler', () => ({
   exitHandler: (...args: unknown[]) => mockExitHandler(...args),
 }));
@@ -75,7 +75,7 @@ describe('createVirtualSymlink', () => {
   it('should update dependencies if fireDependencies are present in original package.json', async () => {
     mockRunCommand.mockImplementationOnce(() => Promise.resolve(true));
     await createVirtualSymlink(fakePackageJson, outFolder, outFolderName);
-    expect(mockCopyPackages).toHaveBeenCalledTimes(1);
+    // expect(mockCopyPackages).toHaveBeenCalledTimes(1);
     expect(mockModifyJson).toHaveBeenCalledTimes(1);
     expect(mockRunCommand).toHaveBeenCalledTimes(1);
     expect(mockExitHandler).toHaveBeenCalledWith(fakePackageJson, true);
@@ -85,7 +85,7 @@ describe('createVirtualSymlink', () => {
     process.argv.push('--buildCommand');
     mockRunCommand.mockImplementationOnce(() => Promise.resolve(true));
     await createVirtualSymlink(fakePackageJson, outFolder, outFolderName);
-    expect(mockCopyPackages).toHaveBeenCalledTimes(1);
+    // expect(mockCopyPackages).toHaveBeenCalledTimes(1);
     expect(mockBuildPackages).toHaveBeenCalledTimes(1);
     expect(mockModifyJson).toHaveBeenCalledTimes(1);
     expect(mockRunCommand).toHaveBeenCalledTimes(1);

src/create-virtual-symlink.ts

@@ -1,11 +1,10 @@
 import { includes, nextOrDefault } from './helpers/args-extractors';
 import { buildPackages } from './helpers/build-packages';
-import { copyPackages } from './helpers/copy-packages';
 import { exitHandler } from './helpers/exit-handler';
 import { modifyJson } from './helpers/modify-json';
-import { readExcludes } from './helpers/read-excludes';
 import { revertJson } from './helpers/revert-json';
 import { runCommand } from './helpers/run-command';
+import { Worker } from './helpers/worker';
 import {
   DEFAULT_RUNNER,
   FireLinkConfig,
@@ -27,13 +26,6 @@ export async function createVirtualSymlink(
     packageJson.fireConfig.runner ||
     DEFAULT_RUNNER;
 
-  const excludes = [
-    ...(packageJson.fireConfig.excludes || []),
-    ...(await readExcludes(
-      packageJson.fireConfig.excludesFileName || '.fireignore',
-    )),
-  ];
-
   if (includes(Tasks.REVERT)) {
     return await revertJson(
       WorkingFiles.PACKAGE_JSON,
@@ -49,9 +41,7 @@ export async function createVirtualSymlink(
       dep,
       folder: linkedDepndencies[dep],
     }));
-    await copyPackages(dependencies)(outFolder)(outFolderName)(excludes)(
-      includes(Tasks.USE_NATIVE_COPY) || packageJson.fireConfig.useNativeCopy,
-    );
+
     if (includes(Tasks.BUILD)) {
       try {
         await buildPackages(outFolder, outFolderName);
@@ -75,6 +65,9 @@ export async function createVirtualSymlink(
   }
 
   try {
+    if (includes(Tasks.BOOTSTRAP)) {
+      await Worker({ command: 'npm', args: ['install'] });
+    }
     if (!includes(Tasks.NO_RUNNER)) {
       await runCommand(runner, process.argv);
     }

src/helpers/build-packages.ts

@@ -11,14 +11,11 @@ export async function buildPackages(outFolder: string, outFolderName: string) {
     (
       await promisify(readdir)(join(outFolder, outFolderName))
     ).map(async (dir) => {
-      await Worker(
-        {
-          command: 'npx',
-          args: (nextOrDefault(Tasks.BUILD, 'tsc') as string).split(' '),
-          cwd: join(outFolder, outFolderName, dir),
-        },
-        false,
-      );
+      await Worker({
+        command: 'npx',
+        args: (nextOrDefault(Tasks.BUILD, 'tsc') as string).split(' '),
+        cwd: join(outFolder, outFolderName, dir),
+      });
     }),
   );
 }

src/helpers/run-command.ts

@@ -12,12 +12,7 @@ export async function runCommand(
       runner,
       ...args
         .slice(2)
-        .filter(
-          (a) =>
-            a !== Tasks.LEAVE_CHANGES &&
-            a !== Tasks.REVERT &&
-            a !== Tasks.BUILD,
-        ),
+        .filter((a) => !Object.values(Tasks).includes(a as never)),
     ],
   });
 }