Add wrappers for starting and stopping modal windows #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue. The reference is needed because the caller may still need to use the window after the dialog is finished.
|
Appreciate the PR. :) It's been a few years since I touched this particular functionality, but (IIRC) I think I opted not to expose these because modern macOS modal views should really be using the sheets API. The That said, I think the PR is probably still useful - but I'd maybe add some additional documentation to the function docs that just notes the above. I also think you're right and that |
…:app module. It is now being used outside of filesystem, and this more closely mirrors the location of this enum with AppKit.
|
Documentation added, and |
Specifically, allow windows with delegates to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add appropriate wrappers to
Appfor the following underlyingNSApplicationmethods:This also adds an implementation of
IntoforModalResponse, which was needed by the above wrappers.One open question concerns the location of
ModalResponsewithin cacao. Previous to this change,ModalResponsewas only used by thefilesystemmodule, but this extends its use more broadly. Within AppKit,ModalResponseis a subclass ofNSApplication, so maybe moving it to theappmodule in cacao is more appropriate. We don't need to make that change now, just pointing out the inconsistency.Tested using a local project invoking these methods in place of their own implementations.