Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "simplify webpack config" #333

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

ryoppippi
Copy link
Owner

@ryoppippi ryoppippi commented Sep 19, 2024

Reverts #330

fixes: #331

Summary by CodeRabbit

  • New Features

    • Enhanced documentation for the unplugin-typia plugin, clarifying usage with different Node.js versions and module systems.
    • Updated examples for integrating the plugin based on Node.js version compatibility.
  • Refactor

    • Improved Webpack configuration setup for better clarity and maintainability, including conditional mode settings based on the environment.
  • Documentation

    • Added installation instructions for the jiti package and updated usage examples in the README for better usability.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unplugin-typia-nextjs ⬜️ Ignored (Inspect) Sep 19, 2024 9:01pm

Copy link

coderabbitai bot commented Sep 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve a refactoring of the Webpack configuration in webpack.config.ts, simplifying the plugin import process and restructuring the configuration object for clarity. The README and documentation for the unplugin-typia package have been updated to provide clearer instructions for using the plugin with different Node.js versions and module systems, specifically addressing the use of jiti and require based on version compatibility.

Changes

File Change Summary
examples/webpack-minimal/webpack.config.ts Refactored Webpack configuration to use CommonJS require syntax for UnpluginTypia, restructured the configuration object for clarity, conditionally set the mode property, and added production-specific plugins.
packages/unplugin-typia/README.md Enhanced documentation with usage instructions for different Node.js versions, clarified the use of jiti for Node < 20.17.0 and require for Node >= 20.17.0, and updated example code snippets accordingly.
packages/unplugin-typia/src/webpack.ts Updated documentation for the unplugin-typia Webpack plugin, specifying instructions for CommonJS module systems based on Node.js version, and provided distinct examples for using jiti and require.

Possibly related PRs

  • simplify webpack config #330: The changes in this PR involve a significant restructuring of the webpack.config.ts file, which directly relates to the refactoring of the Webpack configuration setup in the main PR.

Poem

In the meadow where the bunnies play,
A new config has come our way.
With clearer paths and plugins bright,
We hop along, all feels just right!
For Node and Webpack, we now cheer,
A joyful leap, the changes here! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ryoppippi ryoppippi merged commit d250a0f into main Sep 19, 2024
12 of 13 checks passed
@ryoppippi ryoppippi deleted the revert-330-feature/webpack branch September 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q. How to work in webpack
1 participant