Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #2950 #3002

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fixes for issue #2950 #3002

wants to merge 15 commits into from

Conversation

gjvalenz
Copy link
Contributor

Please look over to ensure everything is fine! I did my own testing, but it's always better to have multiple pairs of eyes rather than just one. Be warned: It's a big pull!

…e it for extra clarity alongside aria-valuenow
… explicit about their function -- cannot change name due to radio groups
…on't parse side content at all times, only when drawer is opened
…e it for extra clarity alongside aria-valuenow
… explicit about their function -- cannot change name due to radio groups
…on't parse side content at all times, only when drawer is opened
@saadeghi saadeghi self-assigned this Apr 28, 2024
@nandi95
Copy link
Contributor

nandi95 commented May 1, 2024

Do any of these need aria-live?

@gjvalenz
Copy link
Contributor Author

gjvalenz commented May 3, 2024

Do any of these need aria-live?

Good question.

I think countdown and radial progress might need them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants