Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nginx conf and dockerization #635

Closed
wants to merge 3 commits into from
Closed

fix nginx conf and dockerization #635

wants to merge 3 commits into from

Conversation

nabeelnoor
Copy link

@nabeelnoor nabeelnoor commented Aug 30, 2023

Description

Fixed Dockerization of the react app, previously, if you click on any link (or use react-router), docker will give you 404, because it only know the hard-coded location of the HTML file. Right now I am serving the dockerize app through nginx and set the conf for nginx to first try other routes from react app and if not found then gives 404.

Fixes #629

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-folio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:13am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker error SyntaxError: Unexpected token ; (and my suggested fix)
1 participant