maybe_download: use RequestException that includes connection err…

…ors, timeouts, ssl errors, not only http errors
saezlab · Sep 15, 2023 · 0b2f96f · 0b2f96f
1 parent 11a0e3c
commit 0b2f96f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/omnipath/_core/downloader/_downloader.py b/omnipath/_core/downloader/_downloader.py
@@ -7,10 +7,11 @@
 import logging
 import traceback
 
-from requests import Request, Session, HTTPError, PreparedRequest
+from requests import Request, Session, PreparedRequest
 from tqdm.auto import tqdm
 from urllib3.util import Retry
 from requests.adapters import HTTPAdapter
+from requests.exceptions import RequestException
 
 from omnipath._core.utils._options import Options
 from omnipath.constants._pkg_constants import (
@@ -140,7 +141,7 @@ def maybe_download(
             else:
                 try:
                     res = self._download(req)
-                except HTTPError:
+                except RequestException:
                     logging.warn(f"Failed to download from `{domain}`.")
                     logging.warn(traceback.format_exc())
                     continue