Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: api kit improvements #1135

Merged
merged 22 commits into from
Feb 18, 2025
Merged

chore: api kit improvements #1135

merged 22 commits into from
Feb 18, 2025

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Feb 12, 2025 •
edited
Loading

What it solves

Resolves #1121 and #1127

How this PR fixes it

This was linked to issues Feb 14, 2025
[api-kit] Update types, options and improvements #1121
Closed
Add valueDecoded to the DecodedParameters type in types-kit #1127
Closed
@coveralls
Copy link

coveralls commented Feb 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13368237445

Details

  • 53 of 70 (75.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 78.879%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-kit/src/SafeApiKit.ts 51 68 75.0%
Totals Coverage Status
Change from base Build 13326625417: 1.0%
Covered Lines: 897
Relevant Lines: 1069
💛 - Coveralls

@dasanra dasanra marked this pull request as ready for review February 14, 2025 11:44
@dasanra dasanra requested review from yagopv and DaniSomoza February 14, 2025 12:59
@dasanra dasanra merged commit a50c035 into development Feb 18, 2025
22 checks passed
@dasanra dasanra deleted the api-kit-improvements branch February 18, 2025 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yagopv yagopv yagopv approved these changes

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add valueDecoded to the DecodedParameters type in types-kit [api-kit] Update types, options and improvements
3 participants
@dasanra @coveralls @yagopv