Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 4337 hooks #24

Merged
merged 13 commits into from
Nov 11, 2024
Merged

feat: Add 4337 hooks #24

merged 13 commits into from
Nov 11, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Oct 29, 2024

We are implementing the following updates:

  1. A new Context property, safeOperationOptions, to pass Safe Operations parameters
  2. Hooks for managing Safe Operations:
    • useSafeOperation
    • useSafeOperations
    • usePendingSafeOperations
    • useSendSafeOperation
    • useConfirmSafeOperations
  3. Updating the change configuration hooks (useUpdateThreshold, useUpdateOwners) to use Safe Operations when the safeOperationOptions property is present

@yagopv yagopv linked an issue Oct 29, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11778744891

Details

  • 76 of 119 (63.87%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.1%) to 88.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/createClient.ts 8 10 80.0%
src/hooks/usePendingSafeOperations.ts 3 8 37.5%
src/hooks/useSendSafeOperation.ts 6 14 42.86%
src/hooks/useSafeOperation.ts 5 14 35.71%
src/hooks/useSafeOperations.ts 7 16 43.75%
src/hooks/useConfirmSafeOperation.ts 4 14 28.57%
Totals Coverage Status
Change from base Build 11404649240: -7.1%
Covered Lines: 599
Relevant Lines: 654

💛 - Coveralls

@yagopv yagopv marked this pull request as ready for review November 7, 2024 21:36
@yagopv yagopv requested review from dasanra and DaniSomoza November 7, 2024 21:36
@dasanra dasanra force-pushed the feat/add-4337-support branch from cca5f56 to bbfb0e8 Compare November 8, 2024 13:03
import { useSignerClientMutation } from '@/hooks/useSignerClientMutation.js'
import { useSendTransaction } from '@/hooks/useSendTransaction.js'
import { useDynamicSafeAction } from '../useDynamicSafeAction.js'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { useDynamicSafeAction } from '../useDynamicSafeAction.js'
import { useDynamicSafeAction } from '@hooks/useDynamicSafeAction.js'

@yagopv yagopv merged commit 60b5812 into main Nov 11, 2024
3 checks passed
@yagopv yagopv deleted the feat/add-4337-support branch November 11, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable 4337 configuration
3 participants