Refactor processing of Internal Txs #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
requested changes
Sep 25, 2024
| with only_one_running_task(self, lock_name_suffix=safe_address): | ||
| logger.info("[%s] Start processing decoded internal txs", safe_address) | ||
| index_service: IndexService = IndexServiceProvider() | ||
| number_processed = index_service.process_address(safe_address) |
There was a problem hiding this comment.
Suggested change
| number_processed = index_service.process_address(safe_address) | |
| number_processed = index_service.process_decoded_txs(safe_address) |
process_address sound for me too generic and confusing.
| self.tx_processor.clear_cache(safe_address) | ||
|
|
||
| # Use chunks for memory issues | ||
| number_processed = 0 |
There was a problem hiding this comment.
Suggested change
| number_processed = 0 | |
| total_processed_txs = 0 |
For me number processed could indicate an ID for example, not the total amount of processed transactions.
- Task was refactored into a function in `IndexService` - Automatic reindexing of Safes was disabled. Reindexing issues should be fixed by the scheduled task `reindex_mastercopies_last_hours_task`. Also some Safes were corrupted due to users trying to trick the indexer or Safes converted from L1 -> L2, and reindexing was triggered forever
Uxio0
force-pushed
the
refactor-process-address
branch
from
eba8b2f
to
35c5401
Compare
|
I've just applied your suggestions! |
Uxio0
force-pushed
the
refactor-process-address
branch
from
35c5401
to
d8b78a4
Compare
moisses89
approved these changes
Sep 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexServicereindex_mastercopies_last_hours_task. Also some Safes were corrupted due to users trying to trick the indexer or Safes converted from L1 -> L2, and reindexing was triggered forever