Skip to content

Commit

Permalink
Implemented reviewer feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
S17A05 committed Mar 7, 2024
1 parent 16535d3 commit 65fef98
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions src/sage/algebras/quatalg/quaternion_algebra.py
Original file line number Diff line number Diff line change
Expand Up @@ -3278,10 +3278,12 @@ def cyclic_right_subideals(self, p, alpha=None):

def is_integral(self) -> bool:
r"""
Check whether a quaternion fractional ideal is integral. An ideal in a quaternion algebra
is integral if and only if it is contained in its left order. If the left order is already
defined this method just checks this definition, otherwise it uses one of the alternative
definitions from Lemma 16.2.8 of [Voi2021]_.
Check whether the quaternion fractional ideal ``self`` is integral.
An ideal in a quaternion algebra is integral if and only if it is
contained in its left order. If the left order is already defined
this method just checks this definition, otherwise it uses one
of the alternative definitions from Lemma 16.2.8 of [Voi2021]_.
EXAMPLES::
Expand Down Expand Up @@ -3362,9 +3364,11 @@ def primitive_decomposition(self):

def is_primitive(self) -> bool:
r"""
Check if the quaternion fractional ideal is primitive. An integral left
`\mathcal{O}`-ideal for some order `\mathcal{O}` is called primitive if
for all integers `n > 1` it is not contained in `n\mathcal{O}`
Check whether the quaternion fractional ideal ``self`` is primitive.
An integral left `\mathcal{O}`-ideal for some order `\mathcal{O}`
is called primitive if for all integers `n > 1` it is not
contained in `n\mathcal{O}`
EXAMPLES::
Expand Down

0 comments on commit 65fef98

Please sign in to comment.