Fix construct homset of elliptic curve in Sets() #39051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit b34caea; changes) is ready! 🎉 |
user202729
force-pushed
the
elliptic-curve-homset
branch
from
1f1105e to
1eff5e5
Compare
|
The new commit should make the category of GluedScheme to be category of schemes instead. Previously it was reported as the category of sets, which is not strong enough. |
|
Maybe @yyyyx4 would be suitable to review this (as the one who added the elliptic curve homset functionality in the first place)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Hom(E, E, Sets())is supposed to be the set of homomorphisms between E and E considered as sets. Returning aEllipticCurveHomsetis way too restrictive.Side issue: there are more morphisms in the category of schemes than morphisms in the category of elliptic curves too. (specifically, a morphism in the category of schemes does not need to send origin to origin)
How should this be fixed? (considering that there isn't even a category of elliptic curves as far as I can see?)
📝 Checklist
⌛ Dependencies