Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show continuation lines when doctest crashes #39102

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Dec 9, 2024

I think this makes more sense.

Normally the format is like

sage: code(code)  ## line 1234 ##
'result'

or

sage: code(code)
code(code)  ## line 1234 ##
'result'

with the patch, the display becomes

sage: code(code)
....: code(code)  ## line 1234 ##
'result'

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Dec 9, 2024

Documentation preview for this PR (built with commit 41b39bb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor Author

It's actually a bit difficult to test this because ....: contains ... for the ellipsis… but fine.

@user202729
Copy link
Contributor Author

Thought about reusing one of the crash test? Or should I make a separate one?

Copy link
Member

@saraedum saraedum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for digging into how that machinery works, this certainly makes debugging these crashes a bit easier :)

There's one little typo. Feel free to set to positive review yourself once that is fixed.

.github/workflows/build.yml Outdated Show resolved Hide resolved
Co-authored-by: Julian Rüth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants