-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump gmpy2 to 2.2.1 #39364
base: develop
Are you sure you want to change the base?
bump gmpy2 to 2.2.1 #39364
Conversation
Documentation preview for this PR (built with commit bad5945; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Please format the Checklist correctly.
Thanks! |
we now have a new stable version of gmpy2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39364 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
we now have a new stable version of gmpy2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39364 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
Running the testsuite (SAGE_CHECK) fails with
Presumably the entrypoint moved in the new version |
the main tests are now by pytest; cython tests are done in another test dir, fixed this too. pytest uses hypothesis, which I thus promote to standard package
yes, this is the case, sorry for not checking. Fixed now |
OK now? |
we now have a new stable version of gmpy2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39364 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
we now have a new stable version of gmpy2 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39364 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
This test now tries to download stuff from the internet (the CI tests with poisoned proxy environment variables):
|
@vbraun - this looks pretty wild to me that this PR does trigger this, are you sure it's not something else in your branch? |
Yes, quite certain. I built with and without this PR. Took quite some time to track down... |
@vbraum This might be due to |
we now have a new stable version of gmpy2
📝 Checklist
⌛ Dependencies