Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gmpy2 to 2.2.1 #39364

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

bump gmpy2 to 2.2.1 #39364

wants to merge 5 commits into from

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Jan 22, 2025

we now have a new stable version of gmpy2

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jan 22, 2025

Documentation preview for this PR (built with commit bad5945; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Please format the Checklist correctly.

@dimpase
Copy link
Member Author

dimpase commented Jan 22, 2025

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 23, 2025
    
we now have a new stable version of gmpy2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39364
Reported by: Dima Pasechnik
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 25, 2025
    
we now have a new stable version of gmpy2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39364
Reported by: Dima Pasechnik
Reviewer(s): Kwankyu Lee
@vbraun
Copy link
Member

vbraun commented Jan 26, 2025

Running the testsuite (SAGE_CHECK) fails with

[gmpy2-2.2.1] [spkg-check] python3: can't open file '/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.12.5/var/tmp/sage/build/gmpy2-2.2.1/src/test/runtests.py': [Errno 2] No such file or directory

Presumably the entrypoint moved in the new version

dimpase and others added 3 commits January 27, 2025 09:53
the main tests are now by pytest;
cython tests are done in another test dir, fixed this too.

pytest uses hypothesis, which I thus promote to standard package
@dimpase
Copy link
Member Author

dimpase commented Jan 27, 2025

Presumably the entrypoint moved in the new version

yes, this is the case, sorry for not checking. Fixed now

@dimpase
Copy link
Member Author

dimpase commented Jan 31, 2025

OK now?

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
    
we now have a new stable version of gmpy2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39364
Reported by: Dima Pasechnik
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
    
we now have a new stable version of gmpy2

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39364
Reported by: Dima Pasechnik
Reviewer(s): Kwankyu Lee
@vbraun
Copy link
Member

vbraun commented Feb 8, 2025

This test now tries to download stuff from the internet (the CI tests with poisoned proxy environment variables):

**********************************************************************
File "src/sage/misc/package.py", line 271, in sage.misc.package.pkg_sources
Failed example:
    L = list_packages('standard')
Exception raised:
    Traceback (most recent call last):
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/urllib/request.py", line 1344, in do_open
        h.request(req.get_method(), req.selector, req.data, headers,
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1336, in request
        self._send_request(method, url, body, headers, encode_chunked)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1382, in _send_request
        self.endheaders(body, encode_chunked=encode_chunked)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1331, in endheaders
        self._send_output(message_body, encode_chunked=encode_chunked)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1091, in _send_output
        self.send(msg)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1035, in send
        self.connect()
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1470, in connect
        super().connect()
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/http/client.py", line 1001, in connect
        self.sock = self._create_connection(
                    ^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/socket.py", line 865, in create_connection
        raise exceptions[0]
      File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/socket.py", line 850, in create_connection
        sock.connect(sa)
    TimeoutError: [Errno 110] Connection timed out

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/home/release/Sage/src/sage/doctest/forker.py", line 728, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/release/Sage/src/sage/doctest/forker.py", line 1152, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.misc.package.pkg_sources[1]>", line 1, in <module>
        L = list_packages('standard')
            ^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/release/Sage/src/sage/misc/package.py", line 343, in list_packages
        remote_version = pip_remote_version(p, ignore_URLError=ignore_URLError)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/release/Sage/src/sage/misc/package.py", line 112, in pip_remote_version
        f = urlopen(url, context=default_context())
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@dimpase
Copy link
Member Author

dimpase commented Feb 9, 2025

This test now tries to download stuff from the internet

@vbraun - this looks pretty wild to me that this PR does trigger this, are you sure it's not something else in your branch?

@vbraun
Copy link
Member

vbraun commented Feb 9, 2025

Yes, quite certain. I built with and without this PR. Took quite some time to track down...

@dimpase
Copy link
Member Author

dimpase commented Feb 9, 2025

@vbraum This might be due to hypothesis being bumped to standard without the usual tarball/checksums dance, simply by changing the package type: so the network access you notice is an attempt to install it from the net, delayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants