Finish changing Rational's round method default rounding to even #39486
+8
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #35756 .
(As is, the warning cannot be suppressed)
Related: #37306, #21935
There's a little (large??) problem: previously
K2.<sqrt2> = QuadraticField(2); K2(9/2).round()
returns5
without a warning (because #35756 forget to print the deprecation). Should we add the deprecation first then change this next year?📝 Checklist
⌛ Dependencies