Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement of the rendering of the documentation in polynomial sequence #39487

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Improvement of the rendering of the documentation in polynomial sequence #39487

wants to merge 2 commits into from
+3 −1

Conversation

MercedesHaiech
Copy link

We make a small improvement in the documentation.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@xcaruso xcaruso self-requested a review February 10, 2025 13:01
tscrim
tscrim requested changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement. Just a convention we do. Otherwise LGTM.

src/sage/rings/polynomial/multi_polynomial_sequence.py Outdated Show resolved Hide resolved
@MercedesHaiech
Copy link
Author

Thank you. I committed your change.

tscrim
tscrim approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. (NB: $\star$ \star and $\ast$ \ast (= *) are slightly different symbols. I have no objection to this, but I am noting this in case it was not intended.)

@MercedesHaiech
Copy link
Author

It was intended to slightly change the symbol, but thanks for pointing it out.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 287430a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton fchapoton added the sd128 tickets of Sage Days 128 Le Teich label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

@xcaruso xcaruso Awaiting requested review from xcaruso

Assignees
No one assigned
Labels
c: documentation s: positive review sd128 tickets of Sage Days 128 Le Teich
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MercedesHaiech @tscrim @fchapoton