-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix latex code in one crystal file #39594
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit b7c2a75; changes) is ready! 🎉 |
The lines
in the unicode_art method are the main suspect for the wrong behaviour |
For the unicode art, the rows are just printed in reverse order it looks like since it displays to the left instead of to the right. So just reversing the rows when passed into the table fixes things (line 178): - table = [[None] * (self.cols - len(row)) + row for row in reversed(self)]
+ table = [[None] * (self.cols - len(row)) + list(reversed(row)) for row in reversed(self)] So we can just fix it here if that's okay with you. |
right, indeed, fixed. |
because these are now fixed in sagemath#39594
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
and also notices a bug in the unicode art, fixed here.
The issue about latex was noticed in #38759
📝 Checklist