Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix latex code in one crystal file #39594

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 26, 2025

and also notices a bug in the unicode art, fixed here.

The issue about latex was noticed in #38759

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Feb 26, 2025

Documentation preview for this PR (built with commit b7c2a75; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

The lines

ret.append(row[:-1] + vl)

in the unicode_art method are the main suspect for the wrong behaviour

@tscrim
Copy link
Collaborator

tscrim commented Feb 27, 2025

For the unicode art, the rows are just printed in reverse order it looks like since it displays to the left instead of to the right. So just reversing the rows when passed into the table fixes things (line 178):

-        table = [[None] * (self.cols - len(row)) + row for row in reversed(self)]
+        table = [[None] * (self.cols - len(row)) + list(reversed(row)) for row in reversed(self)]

So we can just fix it here if that's okay with you.

@fchapoton
Copy link
Contributor Author

right, indeed, fixed.

seblabbe added a commit to seblabbe/sage that referenced this pull request Feb 28, 2025
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants